Skip to content

Replace tracing with bevy_log in bevy_render #22652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alice-i-cecile merged 4 commits into from
Jan 23, 2026
Merged

Replace tracing with bevy_log in bevy_render #22652

alice-i-cecile merged 4 commits into from
Jan 23, 2026

Conversation

@natepiano
Copy link
Contributor

@natepiano natepiano commented Jan 22, 2026

Objective

Replace direct tracing dependency with bevy_log in bevy_render for consistency with other bevy crates.

This was split out from #22649 at @IceSentry's request.

Solution

  • Add bevy_log dependency to bevy_render
  • Replace all use tracing::* imports with use bevy_log::*
  • Remove tracing dependency from bevy_render
  • Add event to bevy_log's tracing re-exports (needed by renderer/mod.rs)

Testing

Built with --all-features and ran 3d_scene example.

@natepiano
Replace tracing with bevy_log in bevy_render
b6ebbac 
Replace direct tracing dependency with bevy_log in bevy_render for consistency
with other bevy crates.

Also adds `event` to bevy_log's tracing re-exports.
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change A-Diagnostics Logging, crash handling, error reporting and performance analysis X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 22, 2026
@natepiano natepiano mentioned this pull request Jan 22, 2026
Merged
@natepiano
Copy link
Contributor Author

natepiano commented Jan 22, 2026

the changes are straightforward and compile on my machine - the CI changes are above my pay grade - any idea what's happening?

@alice-i-cecile
Copy link
Member

alice-i-cecile commented Jan 22, 2026

https://github.com/bevyengine/bevy/actions/runs/21261036195/job/61188312464?pr=22652#step:6:523

This is pretty straightforward: looks like a missed import swap. The code is probably cfg-gated; hence why it's not showing up locally. Try a search within the bevy_render directory for tracing of "use tracing" to spot more that you missed :)

IceSentry
IceSentry reviewed Jan 22, 2026
View reviewed changes
IceSentry
IceSentry approved these changes Jan 22, 2026
View reviewed changes
Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I've been mildly annoyed by this for a while so I'm glad it's finally getting fixed!

@alice-i-cecile @IceSentry
CI plz
256fa5d 
Co-authored-by: IceSentry <[email protected]>
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 22, 2026
auto-merge was automatically disabled January 22, 2026 21:53

Head branch was pushed to by a user without write access

@natepiano
Copy link
Contributor Author

natepiano commented Jan 22, 2026 •
edited
Loading

i updated to latest rust (1.93.0) to match CI and when i do cargo fit --all locally it also gets an error from rustfmt - worked on prior version (1.92.0) but not now

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 23, 2026
@alice-i-cecile
Copy link
Member

alice-i-cecile commented Jan 23, 2026

i updated to latest rust (1.93.0) to match CI and when i do cargo fit --all locally it also gets an error from rustfmt - worked on prior version (1.92.0) but not now

We should probably file a bug upstream for this with a reproduction.

Merged via the queue into bevyengine:main with commit 0dab4fb Jan 23, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@IceSentry IceSentry IceSentry approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Diagnostics Logging, crash handling, error reporting and performance analysis A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon

Projects

Rendering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@natepiano @alice-i-cecile @IceSentry